Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit cast and correct types for write_single_value #516

Closed
eyalroz opened this issue May 17, 2023 · 0 comments
Closed

Use explicit cast and correct types for write_single_value #516

eyalroz opened this issue May 17, 2023 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented May 17, 2023

Our stream_t::enqueue_t::write_single_value() implementation implicitly casts a pointer into a CUdeviceptr, and checks for int32_t and int64_t despite the available implementations using uint32_t and uint64_t. Let's fix that.
@eyalroz eyalroz added the bug label May 17, 2023
@eyalroz eyalroz self-assigned this May 17, 2023
eyalroz added a commit that referenced this issue May 17, 2023
@eyalroz
Fixes #516: Now using explicit cast and correct types for `stream_t::…
a24c145 
…enqueue_t::write_single_value()`
eyalroz added a commit that referenced this issue May 17, 2023
@eyalroz
Fixes #516: Now using explicit cast and correct types for `stream_t::…
1e8475e 
…enqueue_t::write_single_value()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz