Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing includes #515

Closed
codecircuit opened this issue May 14, 2023 · 5 comments
Closed

Missing includes #515

codecircuit opened this issue May 14, 2023 · 5 comments

Comments

@codecircuit
Copy link
Contributor

  • stream.hpp uses pool_t defined in memory_pool.hpp
  • memory_pool.hpp uses ipc::ptr_handle_t defined in ipc.hpp
  • nvtx/profiling.hpp uses scoped_existence_ensurer_t defined in api/multi_wrapper_impls/context.hpp
@eyalroz
Copy link
Owner

eyalroz commented May 14, 2023

That's what I get for not having proper unit tests for things. :-(

Will fix this tomorrow.

@eyalroz
Copy link
Owner

eyalroz commented May 15, 2023

How about this? (development branch)

@eyalroz eyalroz self-assigned this May 15, 2023
@eyalroz eyalroz added the bug label May 15, 2023
@codecircuit
Copy link
Contributor Author

in profiling.hpp line 289 the full object definition of scoped_existence_ensurer_t is required. A forward declaration is not sufficient and results into compiler error:

cuda-api-wrappers/src/cuda/nvtx/profiling.hpp(289): error: incomplete type is not allowed
   context::current::detail_::scoped_existence_ensurer_t context_existence_ensurer;

eyalroz added a commit that referenced this issue May 15, 2023
@eyalroz
Copy link
Owner

eyalroz commented May 15, 2023

Ok.

@codecircuit
Copy link
Contributor Author

Thanks, this fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants