Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some array_t copy() code tweaks #429

Closed
eyalroz opened this issue Oct 14, 2022 · 0 comments
Closed

Some array_t copy() code tweaks #429

eyalroz opened this issue Oct 14, 2022 · 0 comments
Assignees
@eyalroz
Labels
task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 14, 2022 •
edited
Loading

  1. CUDA array_t values should be passed to copy functions by const-reference, since they are reference-types, not value-types; and they're not small enough to merit passing them by value. Let's make sure that's what's done everywhere.
  2. We're missing a copy from a (const) region to an array_t - we have the other direction, let's add this one.
@eyalroz eyalroz added the task label Oct 14, 2022
@eyalroz eyalroz self-assigned this Oct 14, 2022
eyalroz added a commit that referenced this issue Oct 14, 2022
@eyalroz
Fixes #429: Passing array_t objects by const-reference to all copy …
c802e6d 
…functions.

* Also, a comment tweak
eyalroz added a commit that referenced this issue Oct 14, 2022
@eyalroz
Fixes #429: Passing array_t objects by const-reference to all copy …
49f56d3 
…functions.

* Also, a comment tweak
@eyalroz eyalroz changed the title Pass array_t's by const-reference to copy functions Some array_t copy() code tweaks Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz