Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When rendering compilation options to a string, we get an extra space #376

Closed
eyalroz opened this issue Jun 24, 2022 · 0 comments
Closed

When rendering compilation options to a string, we get an extra space #376

eyalroz opened this issue Jun 24, 2022 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 24, 2022

When we render compilation options into a string, it ends with an extra space.

To fix this, we'll probably need to write startout instead of endopt, and have that have no effect when the string/stream has not had any characters written to it yet.
@eyalroz eyalroz added the bug label Jun 24, 2022
@eyalroz eyalroz self-assigned this Jun 24, 2022
@eyalroz eyalroz mentioned this issue Jul 22, 2022
Closed
eyalroz added a commit that referenced this issue Jul 22, 2022
@eyalroz
Fixes #376: String-rendered compiler options no longer have an extra …
99a6c42 
…delimiter at the end.

* Also added an `empty()` method to the `marshalled_options_t` class
eyalroz added a commit that referenced this issue Jul 22, 2022
@eyalroz
Fixes #376: String-rendered compiler options no longer have an extra …
f634014 
…delimiter at the end.

* Also added an `empty()` method to the `marshalled_options_t` class
@eyalroz eyalroz closed this as completed in 47c82bf Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz