Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spruce up the FOR_THIS_SCOPE macros #366

Closed
eyalroz opened this issue Jun 8, 2022 · 0 comments
Closed

Spruce up the FOR_THIS_SCOPE macros #366

eyalroz opened this issue Jun 8, 2022 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 8, 2022

The CUDA_DEVICE_OR_THIS_SCOPE() and CUDA_CONTEXT_FOR_THIS_SCOPE() shouldn't take a ctor argument and construct a device or a context respectively; it's better they just take a device or context to begin with. Also, the latter is misnamed as a scoped_device_override. Let's fix this.
@eyalroz eyalroz added the task label Jun 8, 2022
@eyalroz eyalroz self-assigned this Jun 8, 2022
eyalroz added a commit that referenced this issue Jun 8, 2022
@eyalroz
Fixes #366: Spruce up the FOR_THIS_SCOPE macros
75800df 
The `CUDA_DEVICE_OR_THIS_SCOPE()` and `CUDA_CONTEXT_FOR_THIS_SCOPE()` now take a device and a context, respectively; and the namer of the latter upon expansion has been corrected.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #366: Spruce up the FOR_THIS_SCOPE macros
868549a 
The `CUDA_DEVICE_OR_THIS_SCOPE()` and `CUDA_CONTEXT_FOR_THIS_SCOPE()` now take a device and a context, respectively; and the namer of the latter upon expansion has been corrected.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #366: Spruce up the FOR_THIS_SCOPE macros
b32cd5e 
The `CUDA_DEVICE_OR_THIS_SCOPE()` and `CUDA_CONTEXT_FOR_THIS_SCOPE()` now take a device and a context, respectively; and the namer of the latter upon expansion has been corrected.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #366: Spruce up the FOR_THIS_SCOPE macros
59408e1 
The `CUDA_DEVICE_OR_THIS_SCOPE()` and `CUDA_CONTEXT_FOR_THIS_SCOPE()` now take a device and a context, respectively; and the namer of the latter upon expansion has been corrected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz