-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy classes must be move-assignable #356
Labels
Comments
eyalroz
changed the title
proxy classes must be assignable
proxy classes must be at least move-assignable
Jun 5, 2022
eyalroz
changed the title
proxy classes must be at least move-assignable
proxy classes must be move-assignable
Jun 5, 2022
eyalroz
added a commit
that referenced
this issue
Jun 5, 2022
…s necessary * Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator. * Made sure all (relevant) proxies have no copy-assignment operator. * Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`. * primary context assignment operators now actually return primary context references...
eyalroz
added a commit
that referenced
this issue
Jun 5, 2022
…s necessary * Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator. * Made sure all (relevant) proxies have no copy-assignment operator. * Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`. * primary context assignment operators now actually return primary context references...
eyalroz
added a commit
that referenced
this issue
Jun 6, 2022
…s necessary * Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator. * Made sure all (relevant) proxies have no copy-assignment operator. * Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`. * primary context assignment operators now actually return primary context references...
eyalroz
added a commit
that referenced
this issue
Jun 20, 2022
…s necessary * Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator. * Made sure all (relevant) proxies have no copy-assignment operator. * Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`. * primary context assignment operators now actually return primary context references...
eyalroz
added a commit
that referenced
this issue
Jun 20, 2022
…s necessary * Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator. * Made sure all (relevant) proxies have no copy-assignment operator. * Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`. * primary context assignment operators now actually return primary context references...
eyalroz
added a commit
that referenced
this issue
Jun 20, 2022
…s necessary * Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator. * Made sure all (relevant) proxies have no copy-assignment operator. * Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`. * primary context assignment operators now actually return primary context references...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We must be able to pass the proxy classes around easily. They must therefore all be at least move-assignable, with ownership and primary context reference count unit preservation.
As for copy-assignment... maybe for devices, since they don't ever get created. But for the other proxies, I think the policy should be move-assignment only (and use references instead of copying).
The text was updated successfully, but these errors were encountered: