Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std:: -> ::std:: #347

Closed
eyalroz opened this issue May 28, 2022 · 2 comments
Closed

std:: -> ::std:: #347

eyalroz opened this issue May 28, 2022 · 2 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented May 28, 2022 •
edited
Loading

When compiling with CUDA 11.7, we need to use ::std::, not std::, to avoid CUDA's not-quite-standard library.
@eyalroz eyalroz added the bug label May 28, 2022
@eyalroz eyalroz self-assigned this May 28, 2022
@eyalroz eyalroz changed the title Some std::string have creeped in std::string -> ::std::string May 28, 2022
eyalroz added a commit that referenced this issue May 28, 2022
@eyalroz
Fixes #347: std::string -> ::std::string.
6b7cbe3
@eyalroz eyalroz changed the title std::string -> ::std::string std:: -> ::std:: May 28, 2022
eyalroz added a commit that referenced this issue May 28, 2022
@eyalroz
Fixes #347: std:: -> ::std::.
c2ad3ea
eyalroz added a commit that referenced this issue May 28, 2022
@eyalroz
Fixes #347: std:: -> ::std::.
eab86f2
eyalroz added a commit that referenced this issue May 29, 2022
@eyalroz
Fixes #347: std:: -> ::std::.
8c9ed3d
eyalroz added a commit that referenced this issue Jun 2, 2022
@eyalroz
Fixes #347: std:: -> ::std::.
a404609
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #347: std:: -> ::std::.
514cd7c
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #347: std:: -> ::std::.
64f53a3
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #347: std:: -> ::std::.
e126b9d
@nenomius
Copy link

cuda-api-wrappers/src/cuda/api/multi_wrapper_impls/kernel_launch.hpp

Line 172 in fb5a9a6

throw std::invalid_argument("marshalled arguments for a kernel launch must end with a nullptr element");

@eyalroz
Copy link
Owner Author

eyalroz commented Jun 23, 2022

@nenomius : Whoops... :-( Thank you.

eyalroz added a commit that referenced this issue Jun 23, 2022
@eyalroz
Regards #347: A few more occurrences of std rather than ::std hav…
ec62ee0 
…e creeped in - fixing them.
eyalroz added a commit that referenced this issue Jul 10, 2022
@eyalroz
Regards #347: A few more occurrences of std rather than ::std hav…
4ad2295 
…e creeped in - fixing them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyalroz @nenomius