-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vectorAdd_profiled fails to compile with VS2019 #345
Comments
… a thread ID before trying to pass it to the NVTX naming function.
Try it now. |
So, I made some modifications to the code to make the example compile on my end, but it looks like I can't submit a PR on this repo, so I will just list my changes here. I basically replaced every instance of
Then, because |
@Q-Minh : To submit a PR, you clone the repo, create a branch, then submit the PR. |
That's what I did, but I get an HTTP 403 when I attempt to push the branch onto the remote. I don't have permissions. |
The C++ standard checking macros specific to MSVC must also be added wherever any C++17 specific feature is used, for example std::string_view and std::to_char. Additionally, std::size_t evaluates to unsigned long long on some platforms, such that overloads in marshalled_options.hpp must support unsigned long long.
Let me try it again, it might have to do with https vs ssh, since I have multiple github accounts on the same system. |
@eyalroz Yeah, I can't push the branch onto the remote, unfortunately. Might be some problem on my end. Do you mind making the changes for me? The fist change is a pretty quick string search and replace, and the second one is just writing up 2 overloads. :) |
… a thread ID before trying to pass it to the NVTX naming function.
Does it work? |
Yes, it does. |
… a thread ID before trying to pass it to the NVTX naming function.
… a thread ID before trying to pass it to the NVTX naming function.
… a thread ID before trying to pass it to the NVTX naming function.
… a thread ID before trying to pass it to the NVTX naming function.
… a thread ID before trying to pass it to the NVTX naming function.
The example target
vectorAdd_profiled
has the errorcuda-api-wrappers/src\cuda/nvtx/profiling.hpp(339): error : no instance of function template "cuda::profiling::detail_::name_host_thread" matches the argument list
.The text was updated successfully, but these errors were encountered: