This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
fix!: require .spec field in CRD validation #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
|
Wanted to see if test would pass on master. but as expected no it doesn't because the validation schema has been somewhat loose. Setting spec as required e3cd9df would probably pass 🤔 |
Flydiverny
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks from #681