This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
feat: add general support for isBinary for all backends #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninadpage
force-pushed
the
feature/is-binary-general-implementation
branch
from
e51951a
to
5024f21
Compare
Flydiverny
reviewed
Dec 22, 2020
|
Looks like e2e tests are failing due to using old repo URLs I'll see if I can amend that. (fixed by #586) |
ninadpage
force-pushed
the
feature/is-binary-general-implementation
branch
from
5024f21
to
40e7583
Compare
- Add support for `isBinary` in `KVBackend` + tests - Remove specific implementation of `isBinary` from Azure Key Vault & GCP Secrets Manager backends - Update description for `isBinary` field in the CRD to remove Azure-specific details - Update docs
ninadpage
force-pushed
the
feature/is-binary-general-implementation
branch
from
40e7583
to
fccf502
Compare
Flydiverny
approved these changes
Dec 22, 2020
ninadpage
force-pushed
the
feature/is-binary-general-implementation
branch
from
9b2511b
to
297fa4f
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isBinaryinKVBackend+ testsisBinaryfrom Azure Key Vault & GCP Secrets Manager backendsisBinaryfield in the CRD to remove Azure-specific detailsBackground
isBinaryfor specific backends, both using the same approachpropertyis not available inVaultBackend, you cannot handle binary secrets there either.isBinaryinKVBackend.isBinarywithproperty- it is possible (and in fact a requirement for Hashicorp Vault).