This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
GCP Secret Manager Backend Enhancements #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godaddy master
Flydiverny
suggested changes
Apr 24, 2020
There was a problem hiding this comment.
Can you rebase this and revert the version change so the release scripts doesn't get confused :)
Also I take it this is a breaking change from 3.2.0? Seeing as key before had this format: projects/111122223333/secrets/my-secret/versions/latest and now I take it you only need my-secret ?
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "kubernetes-external-secrets", | |||
| "version": "3.2.0", | |||
| "version": "3.2.1", | |||
There was a problem hiding this comment.
Suggested change
| "version": "3.2.1", | |
| "version": "3.2.0", |
It is a bit difficult to alert on sync_calls since they trigger into an error state and may stay there. This adds the gauge last_state. With last_state, people can easily alert on a value < 0 to indicate failure.
Flydiverny
reviewed
Apr 26, 2020
There was a problem hiding this comment.
LGTM except for package-lock.json, not sure why they are changing? assuming you have a mirror or something :) would you mind reverting the file and I'll try to merge! :) @karan-kap
Flydiverny
approved these changes
Apr 26, 2020
This was referenced May 2, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR against the following ticket: #341