fix(logging): show error on missing property (#87)

The polling function was not outputting an error message when a property is missing from a secret.
external-secrets · Jun 6, 2019 · ef8bd5f · ef8bd5f
1 parent 1ac0694
commit ef8bd5f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/backends/kv-backend.js b/lib/backends/kv-backend.js
@@ -35,6 +35,11 @@ class KVBackend extends AbstractBackend {
           this._logger.warn(`Failed to JSON.parse '${value}':`, err)
           return
         }
+
+        if (!(secretProperty.property in parsedValue)) {
+          throw new Error('Could not find property ' + secretProperty.property + ' in ' + secretProperty.key)
+        }
+
         return parsedValue[secretProperty.property]
       }
 

diff --git a/lib/poller.js b/lib/poller.js
@@ -64,7 +64,8 @@ class Poller {
         return this._upsertKubernetesSecret({ secretDescriptor })
       }))
     } catch (err) {
-      this._logger.error('failure while polling the secrets', err)
+      this._logger.error('failure while polling the secrets')
+      this._logger.error(err.toString())
     }
   }