fix: do not skew binary data (#244)

external-secrets · Dec 5, 2019 · 01e0ca2 · 01e0ca2
1 parent b9b20a7
commit 01e0ca2
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 4 deletions.
diff --git a/lib/backends/kv-backend.js b/lib/backends/kv-backend.js
@@ -108,10 +108,16 @@ class KVBackend extends AbstractBackend {
       }), {})
 
     const encodedEntries = Object.entries(plainValues)
-      .map(([name, plainValue]) => [
-        name,
-        (Buffer.from(`${plainValue}`, 'utf8')).toString('base64')
-      ])
+      .map(([name, plainValue]) => {
+        let bufferValue = plainValue
+        if (!(plainValue instanceof Buffer)) {
+          bufferValue = Buffer.from(`${plainValue}`, 'utf8')
+        }
+        return [
+          name,
+          bufferValue.toString('base64')
+        ]
+      })
 
     return Object.fromEntries(encodedEntries)
   }

diff --git a/lib/backends/kv-backend.test.js b/lib/backends/kv-backend.test.js
@@ -382,5 +382,25 @@ describe('kv-backend', () => {
         specOptions: { }
       })
     })
+
+    it('do not skew binary data', async () => {
+      kvBackend._fetchDataValues
+        .resolves([{
+          textProperty: 'text',
+          binaryProperty: Buffer.from('test', 'utf-8'),
+          binaryProperty2: Buffer.from([0xEFBFBDEF, 2, 3])
+        }])
+
+      const manifestData = await kvBackend
+        .getSecretManifestData({
+          spec: { }
+        })
+
+      expect(manifestData).deep.equals({
+        textProperty: 'dGV4dA==', // base 64 value of text
+        binaryProperty: 'dGVzdA==', // base 64 value of test
+        binaryProperty2: '7wID' // base 64 value of binary data
+      })
+    })
   })
 })