Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the CRAN suggesting SystemRequirements field #310

Closed
wants to merge 2 commits into from

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Aug 15, 2023

From https://cran.r-project.org/web/packages/using_rust.html

The package should declare
SystemRequirements: Cargo (Rust's package manager), rustc

@eitsupi eitsupi marked this pull request as ready for review August 15, 2023 04:09
@@ -33,7 +33,7 @@ update_rextendr_version <- function(path, cur_version = NULL) {
}

update_sys_reqs <- function(path) {
cur <- "Cargo (rustc package manager)"
cur <- "Cargo (Rust's package manager), rustc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Using Rust in CRAN Packages

"SystemRequirements: Cargo (Rust's package manager), rustc"

This update is required. Thanks!

@JosiahParry
Copy link
Contributor

@eitsupi can you use styler::style_package() to fix the linter? @Ilia-Kosenkov can you review this PR? It's simple enough and addresses the requirements in https://cran.r-project.org/web/packages/using_rust.html

@eitsupi
Copy link
Contributor Author

eitsupi commented Sep 1, 2023

@eitsupi can you use styler::style_package() to fix the linter?

The error in CI has nothing to do with this change.
The part the linter is complaining about has already been fixed in the main branch by #309

@Ilia-Kosenkov
Copy link
Member

Do a git merge main to pull in lintr fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants