perf: improve req.ips performance

closes #2723
expressjs · Feb 21, 2017 · 485b6f8 · 485b6f8
1 parent 906164b
commit 485b6f8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/History.md b/History.md
@@ -11,6 +11,7 @@ unreleased
   * deps: [email protected]
     - Fix array parsing from skipping empty values
     - Fix compacting nested arrays
+  * perf: improve `req.ips` performance
 
 4.14.1 / 2017-01-28
 ===================

diff --git a/lib/request.js b/lib/request.js
@@ -356,7 +356,12 @@ defineGetter(req, 'ip', function ip(){
 defineGetter(req, 'ips', function ips() {
   var trust = this.app.get('trust proxy fn');
   var addrs = proxyaddr.all(this, trust);
-  return addrs.slice(1).reverse();
+
+  // reverse the order (to farthest -> closest)
+  // and remove socket address
+  addrs.reverse().pop()
+
+  return addrs
 });
 
 /**