A few bugfixes

[ironswordX-dev]

I was trying to use the cookie parser module, but I realized it was making all requests to my site to just be stuck waiting for the server response, and I found there were a few bugs in the code. I fixed them in this pull request, though.

[dougwilson]

Thanks so much! Sorry about your issue. To help ensure this doesn't reoccur and it is functioning as we make changes, please add tests that only pass with your bug fix.

[ironswordX-dev]

What tests?

[dougwilson]

What tests?

So you said there is a bug, and this is a fix. So we have a file under the tests folder with tests to make sure the module works every time we change something. If you fix a bug but don't add any tests, we are likely to break your bug fix on accident.

A test would reproduce the behavior that is causing this module to sit and wait forever as your description states, for example.

If you are not sure how to do this, we can help. Just provide an app and instructions for how to reproduce the hanging behavior you are seeing and we can help make that in to a test.

[ironswordX-dev]

What tests?

So you said there is a bug, and this is a fix. So we have a file under the tests folder with tests to make sure the module works every time we change something. If you fix a bug but don't add any tests, we are likely to break your bug fix on accident.

A test would reproduce the behavior that is causing this module to sit and wait forever as your description states, for example.

If you are not sure how to do this, we can help. Just provide an app and instructions for how to reproduce the hanging behavior you are seeing and we can help make that in to a test.

Ok

[ironswordX-dev]

Also, most of the GitHub tests failed, but most of the 1x.x errors is because I did not put a space at the beginning of a comment

[dougwilson]

Also, most of the GitHub tests failed, but most of the 1x.x errors is because I did not put a space at the beginning of a comment

I see, it is not the tests failing, but the lint check. This is just bc it checks to make sure the code is styled correctly. You can run npm run lint locally to see the code formatting issue to correct those.

[ironswordX-dev]

I was actually just editing it straight from GitHub 😁

[UlisesGascon]

Thanks for this PR @ironswordX-dev!

I have some notes about the changes requested:

• Minimum Node.js version supported currently is Node 0.8, so ES6 is not supported
• I am not sure what are the bugs solved on this PR, can you provide more context (or even tests) to help us understand it better?

Thanks a lot in advance!