-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it work with Async Hooks #414
Conversation
May I know why this PR was closed? |
@edingroot I'm not sure when there's going to be an Express update that transitively pulls these changes in, but if you're in a hurry I think you could tackle it with npm overrides or patch-package. |
I am working on integrating them in to the very next body-parser release. There was a reported potential security issue with body-parser I am investigating is the only hold up. I pushed up the necessary changes, but rolled them back in anticipation of a patch release if this turns out to indeed be a security issue. Everything should be done this week. |
Got it! Thank you all for the great work :) |
The changes are staged on |
This is the reimplementation of #404 using
AsyncResource
instead of promise wrappers, as @Qard advised.Tests were taken in their entirety from the original PR.