Skip to content
This repository has been archived by the owner on Aug 21, 2022. It is now read-only.

add noStackEnvs option #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add noStackEnvs option #2

wants to merge 1 commit into from

Conversation

dankahle
Copy link

Another pull as the last one's copy/paste/edit features messed up the diff. It kinda uglifies a simple module, just throwing it out there for an option. There is a beauty in specifying which envs to not show the stack for. The true/false option is much simpler for the module, I'll give you that, just that this was easier for the user of the module is all. Junks things up though.

@coveralls
Copy link

Coverage Status

Coverage decreased (-66.67%) to 33.33% when pulling 3728116 on dankahle:nostackenvs into df765a5 on expressjs:master.

@dougwilson
Copy link

We will only accept the true/false implementation.

@jonathanong
Copy link
Member

yeah this implementation is over complicated. and process.env.NODE_ENV.toLowerCase() is going to fail if NODE_ENV doesn't happen to be defined.

@dankahle
Copy link
Author

No biggy, just wanted to throw it out there. Thanks for looking at it.

On Thu, Mar 26, 2015 at 1:59 PM, jongleberry [email protected]
wrote:

yeah this implementation is over complicated. and
process.env.NODE_ENV.toLowerCase() is going to fail if NODE_ENV doesn't
happen to be defined.


Reply to this email directly or view it on GitHub
#2 (comment)
.

@jonchurch jonchurch mentioned this pull request Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants