Use thread-local for connecting to redis to avoid race conditions on master failover #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…master failover redis/redis-py#732 APP-2467 APP-3994
ms7s
approved these changes
Sep 19, 2017
flask_redis_sentinel.py
Outdated
| del config['HOST'] | ||
| config['UNIX_SOCKET_PATH'] = host | ||
| def _strip_dict_prefix(orig, prefix): | ||
| return {k[len(prefix):]: v for (k, v) in orig.items() if k.startswith(prefix)} |
There was a problem hiding this comment.
This could use six.iteritems so that the behaviour for copying the config is consistent between Python 2 and 3.
| the_class = config.get(config_key, default_class) | ||
| if isinstance(the_class, six.string_types): | ||
| the_class = import_string(the_class) | ||
| config.pop(config_key, None) |
There was a problem hiding this comment.
Is it necessary to remove the key from config?
There was a problem hiding this comment.
I wanted the config to be clean when it's passed to the function that matches the keys to the constructor arguments. In this case I know I don't want the class name to be passed as an argument. I can remove it if you prefer.
There was a problem hiding this comment.
I see, let's keep it as it is then.
capkovic
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for this problem:
redis/redis-py#732