Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): document additional metro overrides #573

Conversation

erquhart
Copy link

@erquhart erquhart commented May 13, 2023

Motivation

Recommendation from metro maintainer: facebook/metro#979 (comment)

  • Docs say to use metro and metro-resolver 0.76.0 or newer
  • Many folks, like me, will try using a range to stay up to date
  • As of 0.76.4, other metro packages being at different versions cause errors and build failures

Execution

  • Add additional metro overrides to docs that are known to be required for 0.76.4:
    • metro-config
    • metro-transform-worker
  • Add a troubleshooting note for folks that may run into metro package version sync issues

@erquhart
Copy link
Author

Goes without saying, but feel free to close w/o merging if this feels too specific to be generally useful. Thanks for a fantastic lib 🚀

@erquhart
Copy link
Author

@EvanBacon added npm instructions too 👍

@EvanBacon
Copy link
Contributor

Closing in favor of #734 -- also metro overrides aren't needed in SDK 49

@EvanBacon EvanBacon closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants