Add extraModulesForBridge impl to RCTInstance
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjhughes
changed the title
RCTInstance
alanjhughes
changed the title
RCTInstanceextraModulesForBridge impl to RCTInstance
Kudo
approved these changes
Sep 27, 2024
| @@ -298,7 +298,8 @@ - (void)show | |||
|
|
|||
| [self updateStats]; | |||
|
|
|||
| [RCTKeyWindow() addSubview:self.container]; | |||
| UIWindow *window = RCTSharedApplication().delegate.window; | |||
| [window addSubview:self.container]; | |||
There was a problem hiding this comment.
maybe add comment and have a separate commit for this change. that would help react-native-lab upgrade in the future. e.g. in case the extraModulesForBridge: change is upstreamed, we can keep this RCTSharedApplication() change without manually split commits while upgrade.
tsapeta
approved these changes
Sep 29, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Oct 8, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Oct 10, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Oct 16, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Oct 17, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Oct 23, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Oct 29, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Nov 14, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Nov 22, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Dec 9, 2024
gabrieldonadel
pushed a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To load our bridge modules we need the RCTInstance to call
extraModulesForBridgeon theRCTTurboModuleManagerDelegatewhich will be our app delegate. Also, I needed to revert facebook#43476 as it was causing the performance monitor to be added to the dev menus window instead of the app.