[sms] Fix MFMessageComposeViewController being initialized from non-main thread
#8575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I got one crash while running tests for
expo-sms. It was caused byMFMessageComposeViewControllerbeing initialized not from the main thread. This view controller of course extends UIViewController so it should always be called from the main thread.How
Changed
methodQueueof the exported module. All existing methods use this class, so it's probably better than wrapping specific parts of code bydispatch_async.Test Plan
I wasn't able to reproduce this crash again, as expected 😅 Tested using
test-suiteexamples.