Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-gl-cpp] fix crash in react-native 0.62 #8352

Merged
merged 2 commits into from
May 20, 2020
Merged

[expo-gl-cpp] fix crash in react-native 0.62 #8352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf56e0
[expo-gl-cpp] fix crash in react-native 0.62
wkozyra95 May 18, 2020
b65910f
[expo-gl-cpp] update CHANGELOG
wkozyra95 May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified packages/expo-gl-cpp/android/dist/arm64-v8a/libexpo-gl.so
View file
Open in desktop
Binary file not shown.
Binary file modified packages/expo-gl-cpp/android/dist/armeabi-v7a/libexpo-gl.so
View file
Open in desktop
Binary file not shown.
Binary file modified packages/expo-gl-cpp/android/dist/x86/libexpo-gl.so
View file
Open in desktop
Binary file not shown.
Binary file modified packages/expo-gl-cpp/android/dist/x86_64/libexpo-gl.so
View file
Open in desktop
Binary file not shown.
4 changes: 1 addition & 3 deletions packages/expo-gl-cpp/cpp/EXGLContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ UEXGLContextId EXGLContext::ContextCreate(JSGlobalContextRef jsCtx) {
jsEXGLContextMap = JSObjectMake(jsCtx, nullptr, nullptr);
EXJSObjectSetValueWithUTF8CStringName(jsCtx, jsGlobal, "__EXGLContexts", jsEXGLContextMap);
}
std::stringstream ss;
ss << exglCtxId;
auto exglCtxIdStr = ss.str();
auto exglCtxIdStr = std::to_string(exglCtxId);
EXJSObjectSetValueWithUTF8CStringName(jsCtx, jsEXGLContextMap,
exglCtxIdStr.c_str(), exglCtx->getJSObject());

Expand Down
1 change: 1 addition & 0 deletions packages/expo-gl/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@

### 🐛 Bug fixes

- Fix crash in React Native 0.62 when creating a context. ([#8352](https://github.com/expo/expo/pull/8352) by [@wkozyra95](https://github.com/wkozyra95))
- Allow createElement & unstable_createElement usage for web. ([#7995](https://github.com/expo/expo/pull/7995) by [@wood1986](https://github.com/wood1986))
- Fix depth/stencil buffers not working correctly with `three.js`. ([#7543](https://github.com/expo/expo/pull/7543) by [@tsapeta](https://github.com/tsapeta))