[docs] Fix hydration issue for Video component #25072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simek
approved these changes
Oct 27, 2023
marklawlor
pushed a commit
that referenced
this pull request
Oct 30, 2023
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> After upgrading `react-player` dependency to the latest, the following hydration issue started occurring where we use `Video` component.  I found a similar open issue in React Player GitHub repo (cookpete/react-player#1474) where it states that the library is not SSR friendly and this issue happens with React 18. # How <!-- How did you build this feature or fix this bug and why? --> Apply the workaround suggested [here](cookpete/react-player#1474 (comment)) which implies to lazy load the player using Next.js dynamic imports. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> Tested this locally and there doesn't seem to be the hydration error on docs where we use the `Video` component. To test it locally, run docs locally and go to: http://localhost:3002/develop/development-builds/introduction/ # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
After upgrading
react-playerdependency to the latest, the following hydration issue started occurring where we useVideocomponent.I found a similar open issue in React Player GitHub repo (cookpete/react-player#1474) where it states that the library is not SSR friendly and this issue happens with React 18.
How
Apply the workaround suggested here which implies to lazy load the player using Next.js dynamic imports.
Test Plan
Tested this locally and there doesn't seem to be the hydration error on docs where we use the
Videocomponent.To test it locally, run docs locally and go to: http://localhost:3002/develop/development-builds/introduction/
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).