Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-image-picker] Bump cropper version to fix eas build #23191

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

alexandrius
Copy link
Contributor

@alexandrius alexandrius commented Jun 29, 2023

Why

Android Image Cropper lib manifest includes multiple <activity/> elements in the manifest. They actually removed those in the next version. The activity elements included style tag - causing app build fail on SDK49-Beta:

[stderr] 
/home/expo/workingdir/build/android/app/src/debug/AndroidManifest.xml:41:13-49 Error:
[stderr] 
	Attribute activity#androidx.test.core.app.InstrumentationActivityInvoker$BootstrapActivity@theme value=(@android:style/Theme) from [com.github.CanHub:Android-Image-Cropper:4.3.0] AndroidManifest.xml:41:13-49
[stderr] 
	is also present at [androidx.test:core:1.5.0] AndroidManifest.xml:30:13-56 value=(@style/WhiteBackgroundTheme).
[stderr] 
	Suggestion: add 'tools:replace="android:theme"' to <activity> element at AndroidManifest.xml:38:9-45:20 to override.
[stderr] 
/home/expo/workingdir/build/android/app/src/debug/AndroidManifest.xml:49:13-49 Error:
[stderr] 
	Attribute activity#androidx.test.core.app.InstrumentationActivityInvoker$EmptyActivity@theme value=(@android:style/Theme) from [com.github.CanHub:Android-Image-Cropper:4.3.0] AndroidManifest.xml:49:13-49
[stderr] 
	is also present at [androidx.test:core:1.5.0] AndroidManifest.xml:38:13-56 value=(@style/WhiteBackgroundTheme).
[stderr] 
	Suggestion: add 'tools:replace="android:theme"' to <activity> element at AndroidManifest.xml:46:9-53:20 to override.
[stderr] 
/home/expo/workingdir/build/android/app/src/debug/AndroidManifest.xml:57:13-56 Error:
[stderr] 
	Attribute activity#androidx.test.core.app.InstrumentationActivityInvoker$EmptyFloatingActivity@theme value=(@android:style/Theme.Dialog) from [com.github.CanHub:Android-Image-Cropper:4.3.0] AndroidManifest.xml:57:13-56
[stderr] 
	is also present at [androidx.test:core:1.5.0] AndroidManifest.xml:46:13-62 value=(@style/WhiteBackgroundDialogTheme).
[stderr] 
	Suggestion: add 'tools:replace="android:theme"' to <activity> element at AndroidManifest.xml:54:9-61:20 to override.

How

Changed 4.3.0 to 4.3.1

Test Plan

  • Install the library in an empty project
  • Build the app

Checklist

@alexandrius alexandrius changed the title [expo-image-picker] Bump cropper version [expo-image-picker] Bump cropper version to fix eas build Jun 29, 2023
@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 29, 2023
@brentvatne brentvatne requested review from alanjhughes and tsapeta and removed request for Simek, kbrandwijk and amandeepmittal June 30, 2023 21:45
Copy link
Collaborator

@alanjhughes alanjhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍 Just one change.

packages/expo-image-picker/package.json Outdated Show resolved Hide resolved
docs/react-native-website Outdated Show resolved Hide resolved
packages/expo-image-picker/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alanjhughes alanjhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@superyarik
Copy link
Contributor

hey @alexandrius can this issue fixed in SDK49 affect my EAS Build with SDK48? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants