-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-image-picker] Bump cropper version to fix eas build #23191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrius
requested review from
Simek,
amandeepmittal,
kbrandwijk and
lukmccall
as code owners
June 29, 2023 11:57
alexandrius
changed the title
[expo-image-picker] Bump cropper version
[expo-image-picker] Bump cropper version to fix eas build
Jun 29, 2023
expo-bot
added
bot: suggestions
ExpoBot has some suggestions
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Jun 29, 2023
brentvatne
requested review from
alanjhughes and
tsapeta
and removed request for
Simek,
kbrandwijk and
amandeepmittal
June 30, 2023 21:45
alanjhughes
requested changes
Jul 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 👍 Just one change.
alanjhughes
requested changes
Jul 1, 2023
tsapeta
requested changes
Jul 1, 2023
alanjhughes
approved these changes
Jul 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
tsapeta
approved these changes
Jul 2, 2023
This was referenced Jul 6, 2023
hey @alexandrius can this issue fixed in SDK49 affect my EAS Build with SDK48? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: passed checks
ExpoBot has nothing to complain about
published
Changes from the PR have been published to npm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Android Image Cropper lib manifest includes multiple
<activity/>
elements in the manifest. They actually removed those in the next version. The activity elements included style tag - causing app build fail on SDK49-Beta:How
Changed 4.3.0 to 4.3.1
Test Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).