Remove fetch-mock #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 168 168
Branches 32 33 +1
=========================================
Hits 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vonovak
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
For mocking network calls, https://mswjs.io/docs/basics/intercepting-requests is the preferred option these days afaik. Just mentioning it for potential future use.
Looks good to me 👍
Using jest to mock at the boundaries of node-fetch directly is simpler, and makes type mismatches between the mock and the real module less likely.
nicknovitski
force-pushed
the
rm-fetch-mock
branch
from
01ddd6d
to
6334dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using jest to mock at the boundaries of node-fetch directly is simpler, and makes type mismatches between the mock and the real module less likely.