Remove values mock from test #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknovitski
requested review from
a team and
vonovak
and removed request for
a team
It's easy for this mock to fall out of sync with the actual module, and solutions which would prevent this would be verbose and cluttered. The only thing it achieves is keeping the tests fast with a lower retry timeout, and that can also be achieved with a switch on NODE_ENV.
nicknovitski
force-pushed
the
no-module-mock
branch
from
d0747b4
to
ca33e3d
Compare
vonovak
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy for this mock to fall out of sync with the actual module, and solutions which would prevent this would be verbose and cluttered. The only thing it achieves is keeping the tests fast with a lower retry timeout, and that can also be achieved with a switch on
NODE_ENV.