fix(continuous-deploy-fingerprint): correct expiration date logic for build validation #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… build validation This commit fixes the logic for validating build expiration dates in the continuous deployment fingerprint process. The condition was incorrectly set to exclude builds that expire after tomorrow, when it should have been excluding builds that expire before tomorrow.
|
@wschurman sorry for the tag, but this is a bug fix that needs to go in or the fingerprint CD flow is going to be broken. |
wschurman
approved these changes
Sep 19, 2024
|
Thanks for the fix! Dates are hard lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the logic for validating build expiration dates in the continuous deployment fingerprint process. The condition was incorrectly set to exclude builds that expire after tomorrow, when it should have been excluding builds that expire before tomorrow.
Linked issue
#303