This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
enable horizontal scrolling of tabs #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not trying to duplicate the work from @JohnClema on #325 but I wanted to get the horizontal scrolling in soon and his PR has been sitting for a few days. I think his PR has other work that should be considered but I used the variable names suggested to him in the PR comments |
nehvaleem
suggested changes
Dec 28, 2016
| @@ -226,6 +228,7 @@ class ExNavigationSlidingTab extends PureComponent<any, Props, State> { | |||
| tabStyle: this.props.tabStyle, | |||
| labelStyle: this.props.labelStyle, | |||
| renderLabel: renderLabelFn, | |||
| tabBarScrollEnabled: this.props.tabBarScrollEnabled, | |||
There was a problem hiding this comment.
it should be:
scrollEnabled: this.props.tabBarScrollEnabled,
as you passing it to TabBar
There was a problem hiding this comment.
doh! That's what I get for using find/replace for variable names
|
@nehvaleem fixed typo |
|
#361 builds off of the work in the PR to allow the list of tabs to be dynamic |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see:
#325
#336