support transucent status bar #104

chirag04 · 2016-09-20T21:07:11Z

This should work now:

defaultRouteConfig={{
    statusBar: {
        translucent: true,
    },
}}

chirag04 · 2016-09-20T21:08:26Z

ah damn! wrong branching!

chirag04 · 2016-09-20T21:47:08Z

src/ExNavigationStack.js

@@ -481,10 +496,15 @@ class ExNavigationStack extends PureComponent<any, Props, State> {
      latestRouteConfig.navigationBar.visible !== false;

    // TODO: add height and statusBarHeight options here


remove the todo

satya164 · 2016-09-22T03:01:48Z

BTW, navigationBar and TabNavigation take translucent: true, so maybe keep the naming consistent.

chirag04 · 2016-09-22T13:17:30Z

good point @satya164 . I updated the PR.

satya164 · 2016-09-24T22:02:40Z

src/ExNavigationStack.js

+    let height = NavigationBar.DEFAULT_HEIGHT;
+
+    if (latestRouteConfig.statusBar && latestRouteConfig.statusBar.translucent) {
+      height = NavigationBar.DEFAULT_HEIGHT_WITHOUT_STATUS_BAR + 24;


On Android, statusbar height is 25

yeah. @brentvatne defined it at 24 already when in exponent env. I just mirrored that.

also for some reason 25 had a weird spacing issue.

@chirag04 Hmm... okay, it's wrong though I remember when @brentvatne changed my app to exponent he had used 24 and it felt like the header title wasn't vertically centered (since it was 1px off).

What's the issue?

@satya164 updated the PR. I can't reproduce the 1px off thing in my app anymore. 25 works in my app for now.

satya164 · 2016-09-24T22:03:17Z

src/ExNavigationStack.js

+    // pass the statusBarHeight to headerComponent if statusBar is translucent
+    let statusBarHeight = STATUSBAR_HEIGHT;
+    if (latestRouteConfig.statusBar && latestRouteConfig.statusBar.translucent) {
+      statusBarHeight = 24;


We should probably keep this in a constant

chirag04 · 2016-09-26T21:45:19Z

@brentvatne i'm unable to flow check this PR. for whatever reason it is checking react-native in node_modules.

alexcurtis · 2016-10-15T14:06:00Z

LGTM! :-D

skevy · 2016-10-28T00:56:50Z

@chirag04 want to fix the merge conflicts here?

chirag04 · 2016-10-28T14:59:43Z

@skevy @brentvatne rebased.

cyprusglobe · 2016-10-31T19:29:11Z

LGTM!

@brentvatne

@brentvatne This should work now: Closes #104 fbshipit-source-id: 5dd1eb8

chirag04 commented Sep 20, 2016

View reviewed changes

satya164 reviewed Sep 24, 2016

View reviewed changes

chirag04 force-pushed the trans-status-bar branch from 09acfc8 to ab211a8 Compare September 26, 2016 19:02

chirag04 added 4 commits October 28, 2016 10:58

support transucent status bar

fc539ae

keep is consistent with tabbar etc

860ca60

updates

9d4192e

use 25 as height

4c52e4a

chirag04 force-pushed the trans-status-bar branch from 3bfd7d2 to 4c52e4a Compare October 28, 2016 14:58

brentvatne closed this Nov 14, 2016

expbot pushed a commit that referenced this pull request Nov 14, 2016

support transucent status bar

f46b49e

@brentvatne This should work now: Closes #104 fbshipit-source-id: 5dd1eb8

cooperka mentioned this pull request Nov 18, 2016

Allow setting statusBar height via route config #263

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support transucent status bar #104

support transucent status bar #104

chirag04 commented Sep 20, 2016 •

edited

Loading

chirag04 commented Sep 20, 2016

chirag04 Sep 20, 2016

satya164 commented Sep 22, 2016

chirag04 commented Sep 22, 2016

satya164 Sep 24, 2016

chirag04 Sep 26, 2016 •

edited

Loading

satya164 Sep 26, 2016

chirag04 Sep 26, 2016

satya164 Sep 24, 2016

chirag04 Sep 26, 2016

chirag04 commented Sep 26, 2016

alexcurtis commented Oct 15, 2016

skevy commented Oct 28, 2016

chirag04 commented Oct 28, 2016

cyprusglobe commented Oct 31, 2016

		@@ -481,10 +496,15 @@ class ExNavigationStack extends PureComponent<any, Props, State> {
		latestRouteConfig.navigationBar.visible !== false;

		// TODO: add height and statusBarHeight options here

support transucent status bar #104

support transucent status bar #104

Conversation

chirag04 commented Sep 20, 2016 • edited Loading

chirag04 commented Sep 20, 2016

chirag04 Sep 20, 2016

Choose a reason for hiding this comment

satya164 commented Sep 22, 2016

chirag04 commented Sep 22, 2016

satya164 Sep 24, 2016

Choose a reason for hiding this comment

chirag04 Sep 26, 2016 • edited Loading

Choose a reason for hiding this comment

satya164 Sep 26, 2016

Choose a reason for hiding this comment

chirag04 Sep 26, 2016

Choose a reason for hiding this comment

satya164 Sep 24, 2016

Choose a reason for hiding this comment

chirag04 Sep 26, 2016

Choose a reason for hiding this comment

chirag04 commented Sep 26, 2016

alexcurtis commented Oct 15, 2016

skevy commented Oct 28, 2016

chirag04 commented Oct 28, 2016

cyprusglobe commented Oct 31, 2016

chirag04 commented Sep 20, 2016 •

edited

Loading

chirag04 Sep 26, 2016 •

edited

Loading