enable type checking for tests and mocks #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsokal
force-pushed
the
@dsokal/tsconfig-tweaks
branch
from
ef2b35f to
91f03f0
Compare
dsokal
changed the title
dsokal
force-pushed
the
@dsokal/tsconfig-tweaks
branch
from
91f03f0 to
8377d3c
Compare
|
Size Change: +1.46 kB (0%) Total Size: 32.9 MB
|
quinlanj
approved these changes
Apr 13, 2021
packages/eas-cli/package.json
Outdated
| @@ -163,8 +163,9 @@ | |||
| "scripts": { | |||
| "postpack": "rm -f oclif.manifest.json", | |||
| "prepack": "rm -rf build && yarn build && yarn oclif-dev manifest && yarn oclif-dev readme", | |||
| "build": "tsc", | |||
| "watch": "tsc --watch", | |||
| "build": "tsc -p tsconfig.build.json", | |||
There was a problem hiding this comment.
-p flag doesn't readily show up on tsc --help so project flag would be clearer
Suggested change
| "build": "tsc -p tsconfig.build.json", | |
| "build": "tsc --project tsconfig.build.json", |
wkozyra95
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
We don't run type checks on files in
__mocks__and__tests__directories.How
tsconfig.json) and for release/build (tsconfig.build.json).__mocks__and__tests__.typecheckscript to the rootpackage.json. Thanks to that script we can type check tests (and regular code as well) on CI.Test Plan
Tests pass on CI.