Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] parse request body for error only when needed #2784

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

kadikraman
Copy link
Contributor

Why

Fixes a regression I introduced in https://github.com/expo/eas-cli/pull/2771/files
Successful deployments error because the body is already parsed.

How

Only parse the request body when to show the error message when needed.

Test Plan

Ensure eas deploy works without errors.

@kadikraman kadikraman requested a review from kitten December 20, 2024 15:05
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 20, 2024

Size Change: -3.79 kB (-0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -3.79 kB (-0.01%)

compressed-size-action

@kadikraman kadikraman force-pushed the @kadikraman/fix-error-parse branch from 485677a to 102475b Compare December 20, 2024 15:32
Copy link

✅ Thank you for adding the changelog entry!

@kadikraman kadikraman merged commit a1d086f into main Dec 20, 2024
7 checks passed
@kadikraman kadikraman deleted the @kadikraman/fix-error-parse branch December 20, 2024 15:36
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (2a96d04) to head (102475b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/upload.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2784      +/-   ##
==========================================
- Coverage   52.51%   52.51%   -0.00%     
==========================================
  Files         583      583              
  Lines       22581    22582       +1     
  Branches     4452     4452              
==========================================
  Hits        11856    11856              
- Misses      10690    10691       +1     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants