-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pushing existing secret and sensitive variables #2765
base: main
Are you sure you want to change the base?
Support pushing existing secret and sensitive variables #2765
Conversation
Subscribed to pull request
Generated by CodeMention |
8e43bb3
to
d2418ef
Compare
/changelog-entry bug-fix Support pushing existing secret and sensitive environment variables |
Size Change: +6.39 kB (+0.01%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
- Coverage 52.50% 52.49% -0.00%
==========================================
Files 583 583
Lines 22584 22590 +6
Branches 4450 4450
==========================================
+ Hits 11855 11856 +1
- Misses 10694 10699 +5
Partials 35 35 ☔ View full report in Codecov by Sentry. |
/changelog-entry bug-fix Support pushing existing secret and sensitive environment variables |
d2418ef
to
42bcb23
Compare
42bcb23
to
422485f
Compare
✅ Thank you for adding the changelog entry! |
Why
ENG-14486: Support updating secret variables with
eas env:push
#2753
Currently, we don't support adding secrets using the
eas env:push
command. However, this behavior conflicts with the legacyeas secrets:push
command, forcing some users to either convert their secrets to public variables or prefix them withEXPO_SENSITIVE
. This pull request addresses this issue by enabling users to update existing secret or sensitive variables without any additional work.Additionally, the
--force
option has been added to skip prompts.Also, an unintended behavior has been fixed: pushing variables would overwrite the existing
environments
field of eas variables instead of appending to it. If a user has defined a variable in multiple environments and then pushes it to just one, the variable will only be linked to that specific environment.How
force
flag has been added..env
file is already present ineas
, itsvisibility
andenvironments
are preserved.Test Plan
Tested manually