Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] improvements to eas env:exec command #2762

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Dec 11, 2024

Why

Don't throw an error if no readable env vars are present. Make logs less noisy.

How

Don't throw an error if no readable env vars are present. Make logs less noisy.

Test Plan

Tested manually

Copy link
Member Author

szdziedzic commented Dec 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review December 11, 2024 15:20
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 11, 2024

Size Change: +109 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +109 B (0%)

compressed-size-action

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (1c964d2) to head (6a51842).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/exec.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
+ Coverage   52.50%   52.52%   +0.02%     
==========================================
  Files         583      583              
  Lines       22584    22576       -8     
  Branches     4450     4450              
==========================================
  Hits        11855    11855              
+ Misses      10694    10686       -8     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the 12-11-_eas-cli_improvements_to_eas_env_exec_command branch from 7b21760 to 6a51842 Compare December 13, 2024 15:01
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 63e3c1f into main Dec 13, 2024
8 checks passed
@szdziedzic szdziedzic deleted the 12-11-_eas-cli_improvements_to_eas_env_exec_command branch December 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants