Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] tweak message related to channel creation #2735

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Dec 2, 2024

Why

Fixes ENG-12139

How

Improve log message printing out after the channel creation. Add link to the docs describing the channel <-> branch relation.

Test Plan

The changes have been reviewed by running EAS CLI locally. All lint checks and tests are passing.

Preview

Screenshot 2024-12-02 at 13 48 38

@Simek Simek added the no changelog PR that doesn't require a changelog entry label Dec 2, 2024
Copy link

linear bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

github-actions bot commented Dec 2, 2024

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

Generated by CodeMention

Copy link

github-actions bot commented Dec 2, 2024

Size Change: -1.11 kB (0%)

Total Size: 52.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.7 MB -1.11 kB (0%)

compressed-size-action

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.73%. Comparing base (7d60ba2) to head (61fd0e3).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/channel/queries.ts 11.12% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
- Coverage   52.74%   52.73%   -0.00%     
==========================================
  Files         580      580              
  Lines       22277    22278       +1     
  Branches     4355     4357       +2     
==========================================
  Hits        11747    11747              
- Misses      10495    10496       +1     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic requested a review from quinlanj December 4, 2024 15:10
Copy link
Member

@quinlanj quinlanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Simek Simek merged commit f9337f4 into main Dec 5, 2024
10 checks passed
@Simek Simek deleted the @simek/eas-cli-create-channel-wording branch December 5, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants