Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] fix warning for gitignored google services file #2730

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Nov 28, 2024

Why

https://discord.com/channels/695411232856997968/1309202098591633458/1311040361040183429

How

Make warning up to date after recent env vars changes

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review November 28, 2024 12:08
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela
packages/eas-cli/src/build/** @khamilowicz, @sjchmiela

Generated by CodeMention

Copy link

github-actions bot commented Nov 28, 2024

Size Change: -1.29 kB (0%)

Total Size: 52.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.7 MB -1.29 kB (0%)

compressed-size-action

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.73%. Comparing base (7d60ba2) to head (994d4cc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/validate.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2730      +/-   ##
==========================================
- Coverage   52.74%   52.73%   -0.00%     
==========================================
  Files         580      580              
  Lines       22277    22280       +3     
  Branches     4355     4358       +3     
==========================================
  Hits        11747    11747              
- Misses      10495    10498       +3     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the 11-28-_eas-cli_fix_warning_for_gitignored_google_services_file branch from 88eb06c to 994d4cc Compare December 2, 2024 19:01
Copy link

github-actions bot commented Dec 2, 2024

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 868fd39 into main Dec 2, 2024
7 checks passed
@szdziedzic szdziedzic deleted the 11-28-_eas-cli_fix_warning_for_gitignored_google_services_file branch December 2, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants