Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Fix VCS client used for submit:internal #2682

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

sjchmiela
Copy link
Contributor

Why

Counterpart of #2677, applied to submit:internal.

How

Copied the solution from build:internal.

Test Plan

None.

@sjchmiela sjchmiela requested a review from szdziedzic November 12, 2024 12:56
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Nov 12, 2024
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz

Generated by CodeMention

Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

Size Change: -13 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -13 B (0%)

compressed-size-action

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (fdb167d) to head (c8896b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/submit/internal.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
- Coverage   52.94%   52.94%   -0.00%     
==========================================
  Files         576      576              
  Lines       22103    22105       +2     
  Branches     4336     4337       +1     
==========================================
+ Hits        11700    11701       +1     
- Misses      10369    10370       +1     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela merged commit 7eff738 into main Nov 13, 2024
10 of 11 checks passed
@sjchmiela sjchmiela deleted the stanley/fix-submit-internal-too branch November 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants