Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Default build-logger-level to debug when EXPO_DEBUG is set #2676

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Nov 7, 2024

Why

It's convenient to have this be the default value when trying to debug, so that the whole build can be used to debug. Not set on this, but wanted to see what others thought.

Closes ENG-14060.

How

Default when Log.isDebug is true and flag isn't provided.

Test Plan

  1. EXPO_DEBUG=1 neas build, see debug logs in build.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

Copy link

linear bot commented Nov 7, 2024

Copy link

github-actions bot commented Nov 7, 2024

Size Change: +32 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +32 B (0%)

compressed-size-action

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (027d362) to head (4bc0102).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/runBuildAndSubmit.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2676      +/-   ##
==========================================
- Coverage   52.94%   52.94%   -0.00%     
==========================================
  Files         576      576              
  Lines       22101    22103       +2     
  Branches     4335     4336       +1     
==========================================
+ Hits        11699    11700       +1     
- Misses      10368    10369       +1     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman marked this pull request as ready for review November 7, 2024 18:42
Copy link

github-actions bot commented Nov 7, 2024

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/build/** @szdziedzic, @khamilowicz, @sjchmiela

Generated by CodeMention

@wschurman wschurman force-pushed the @wschurman/11-07-_build_default_build-logger-level_to_debug_when_expo_debug_is_set branch from 4bc6bd8 to 256e7bc Compare November 7, 2024 18:43
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, and I believe it would be useful.

I'm curious what @sjchmiela thinks about it.

@szdziedzic szdziedzic requested a review from sjchmiela November 8, 2024 16:04
@wschurman wschurman force-pushed the @wschurman/11-07-_build_default_build-logger-level_to_debug_when_expo_debug_is_set branch from 256e7bc to f5bb6af Compare November 11, 2024 18:44
@wschurman wschurman force-pushed the @wschurman/11-07-_build_default_build-logger-level_to_debug_when_expo_debug_is_set branch from f5bb6af to 4bc0102 Compare November 11, 2024 18:45
Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit fdb167d into main Nov 11, 2024
7 checks passed
@wschurman wschurman deleted the @wschurman/11-07-_build_default_build-logger-level_to_debug_when_expo_debug_is_set branch November 11, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants