Allow $schema in eas.json #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subscribed to pull request
Generated by CodeMention |
|
@szdziedzic do I need to reach out to a reviewer? What's the process for moving this forward? |
|
this seems reasonable to me, but i defer to @byCedric |
szdziedzic
approved these changes
Dec 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
JSON Schemas are an open and well used method of validating json configs and works well with existing tools. While the VSCode Expo plugin exists, working with existing tooling is ideal (and the expo already uses a json schema internally, so the additional lift is minimal).
How
Added to the Joi config
Closes #2600