Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eas-cli): avoid malforming app.json with empty .expo object #2573

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Sep 18, 2024

Why

app.json may contain either a root level .expo object with all config options or no .expo property at all. @expo/config reads them both as valid Expo config files.

This removes the unnecessary .expo change, allowing app.json files without .expo property.

Note, this is just one instance but I think there are more invalid instances within eas-cli. Once SDK 52 is out, I'd love to revise the config loading that we use and get fully rid of this limitation.

How

  • Removed ensureStaticExpoConfigIsValidAsync as this malforms projects using no .expo property

Test Plan

  • $ bun create expo ./test
  • Change app.json to drop the root .expo property (use .expo as root)
  • $ cd ./test
  • $ eas deploy + setup project ID
  • $ eas deploy
  • Subsequent run should be possible without EAS malforming the app.json file.

@byCedric byCedric changed the title @bycedric/eas cli/avoid corrupting appjson fix(eas-cli): avoid malforming app.json with empty .expo object Sep 18, 2024
@byCedric byCedric requested a review from EvanBacon September 18, 2024 16:07
Copy link

github-actions bot commented Sep 18, 2024

Size Change: +907 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +907 B (0%)

compressed-size-action

Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.09%. Comparing base (d33ebe1) to head (d856400).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2573      +/-   ##
==========================================
- Coverage   52.12%   52.09%   -0.03%     
==========================================
  Files         559      559              
  Lines       21111    21101      -10     
  Branches     4317     4315       -2     
==========================================
- Hits        11003    10991      -12     
- Misses       9230     9232       +2     
  Partials      878      878              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit d42cbe0 into main Sep 19, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/avoid-corrupting-appjson branch September 19, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants