fix(eas-cli): avoid malforming app.json
with empty .expo
object
#2573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
app.json
may contain either a root level.expo
object with all config options or no.expo
property at all.@expo/config
reads them both as valid Expo config files.This removes the unnecessary
.expo
change, allowingapp.json
files without.expo
property.How
ensureStaticExpoConfigIsValidAsync
as this malforms projects using no.expo
propertyTest Plan
$ bun create expo ./test
app.json
to drop the root.expo
property (use.expo
as root)$ cd ./test
$ eas deploy
+ setup project ID$ eas deploy
app.json
file.