Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add update:edit command for editing rollout #2503

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Aug 20, 2024

Why

This adds the ability to increase a rollout for an update.

How

Add new command, update:edit that takes the rollout-percentage flag.

Test Plan

$ neas update:edit 63809081-ee5f-4216-add2-b3412aae7a16
✔ New rollout percentage (min: 30, max: 100) … 31
Update group:
Platforms                 android, ios
Runtime Version           1.0.0
Message                   "wat2" (1 hour ago by wschurman)
Code Signing Key          N/A
Is Roll Back to Embedded  No
Rollout Percentage        31%
Group ID                  63809081-ee5f-4216-add2-b3412aae7a16

$ neas update:view 63809081-ee5f-4216-add2-b3412aae7a16
Update group:
Platforms                 android, ios
Runtime Version           1.0.0
Message                   "wat2" (1 hour ago by wschurman)
Code Signing Key          N/A
Is Roll Back to Embedded  No
Rollout Percentage        31%
Group ID                  63809081-ee5f-4216-add2-b3412aae7a16

Copy link
Member Author

wschurman commented Aug 20, 2024

Copy link

github-actions bot commented Aug 20, 2024

Size Change: +1 B (0%)

Total Size: 51.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.1 MB +1 B (0%)

compressed-size-action

@wschurman wschurman marked this pull request as ready for review August 20, 2024 00:33
@wschurman wschurman requested review from quinlanj and removed request for EvanBacon, khamilowicz, sjchmiela and szdziedzic August 20, 2024 00:34
@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_rollbackpercentage_flag_to_update_command branch from 3c850e6 to 85ec3a8 Compare August 20, 2024 00:46
@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_update_edit_command_for_editing_rollout branch from ffcca14 to e80e23c Compare August 20, 2024 00:46
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 26.15385% with 48 lines in your changes missing coverage. Please review.

Project coverage is 52.81%. Comparing base (a28439a) to head (4ff20ce).
Report is 2 commits behind head on main.

Files Patch % Lines
packages/eas-cli/src/commands/update/edit.ts 27.42% 39 Missing and 6 partials ⚠️
...s/eas-cli/src/graphql/mutations/PublishMutation.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2503      +/-   ##
==========================================
- Coverage   52.87%   52.81%   -0.05%     
==========================================
  Files         544      545       +1     
  Lines       20085    20219     +134     
  Branches     4096     4128      +32     
==========================================
+ Hits        10617    10676      +59     
- Misses       8654     8716      +62     
- Partials      814      827      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_rollbackpercentage_flag_to_update_command branch from 85ec3a8 to a150d1f Compare August 21, 2024 16:36
@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_update_edit_command_for_editing_rollout branch from e80e23c to 052eb05 Compare August 21, 2024 16:36
@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_rollbackpercentage_flag_to_update_command branch from a150d1f to 8ac3ba6 Compare August 21, 2024 16:39
@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_update_edit_command_for_editing_rollout branch from 052eb05 to 2481fe5 Compare August 21, 2024 16:40
@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_rollbackpercentage_flag_to_update_command branch from 8ac3ba6 to 6ee4fd1 Compare August 22, 2024 17:59
@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_update_edit_command_for_editing_rollout branch from 2481fe5 to f6c2020 Compare August 22, 2024 18:00
Copy link
Member Author

wschurman commented Aug 22, 2024

Merge activity

  • Aug 22, 2:04 PM EDT: @wschurman started a stack merge that includes this pull request via Graphite.
  • Aug 22, 2:06 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 22, 2:07 PM EDT: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from @wschurman/08-19-_eas-cli_add_rollbackpercentage_flag_to_update_command to graphite-base/2503 August 22, 2024 18:04
@wschurman wschurman changed the base branch from graphite-base/2503 to main August 22, 2024 18:04
@wschurman wschurman force-pushed the @wschurman/08-19-_eas-cli_add_update_edit_command_for_editing_rollout branch from f6c2020 to 4ff20ce Compare August 22, 2024 18:05
Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit 6145542 into main Aug 22, 2024
6 checks passed
@wschurman wschurman deleted the @wschurman/08-19-_eas-cli_add_update_edit_command_for_editing_rollout branch August 22, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants