-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: drop support for Node 16 #2413
Conversation
/changelog-entry chore Update test workflow Node versions to 18, 20, and 22 |
Size Change: -2.72 kB (-0.01%) Total Size: 51.9 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2413 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 530 530
Lines 19509 19509
Branches 3968 3968
=======================================
Hits 10427 10427
Misses 8330 8330
Partials 752 752 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also bump engines.node
s in package.json
s? x-ref: expo/eas-build#406
Yeah, if we decide to drop Node 16 (which I'm suggesting here) we should update the |
This makes the PR a breaking change.
✅ Thank you for adding the changelog entry! |
Why
To support Node 22, we'd need to remove
node-fetch
. Starting from Node 18, we can use the built-in fetch which is based onundici
. Unfortunately, we still need theundici
package to maintain support forhttps_proxy
functionality throughProxyAgent
.Dropping support for Node 16 helps in this transition, and matches our other tooling support (which is LTS+ - both maintenance and active LTS versions).
How
Test Plan
See GitHub Actions.