Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop support for Node 16 #2413

Merged
merged 6 commits into from
Jun 8, 2024
Merged

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jun 7, 2024

Why

  • Node 16 is End Of Life (EOL)
  • Node 18 is currently in maintenance LTS
  • Node 20 is currently in active LTS
  • Node 22 is scheduled to take active LTS status on 2024-10-29

Source: https://nodejs.org/en/about/previous-releases

To support Node 22, we'd need to remove node-fetch. Starting from Node 18, we can use the built-in fetch which is based on undici. Unfortunately, we still need the undici package to maintain support for https_proxy functionality through ProxyAgent.

Dropping support for Node 16 helps in this transition, and matches our other tooling support (which is LTS+ - both maintenance and active LTS versions).

How

  • Removed Node 16 from workflow
  • Added Node 22 to workflow

Test Plan

See GitHub Actions.

@byCedric
Copy link
Member Author

byCedric commented Jun 7, 2024

/changelog-entry chore Update test workflow Node versions to 18, 20, and 22

Copy link

github-actions bot commented Jun 7, 2024

Size Change: -2.72 kB (-0.01%)

Total Size: 51.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.9 MB -2.72 kB (-0.01%)

compressed-size-action

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (eefc133) to head (9fd8baa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2413   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         530      530           
  Lines       19509    19509           
  Branches     3968     3968           
=======================================
  Hits        10427    10427           
  Misses       8330     8330           
  Partials      752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also bump engines.nodes in package.jsons? x-ref: expo/eas-build#406

@byCedric
Copy link
Member Author

byCedric commented Jun 7, 2024

Should we also bump engines.nodes in package.jsons? x-ref: expo/eas-build#406

Yeah, if we decide to drop Node 16 (which I'm suggesting here) we should update the engines too! Sorry, overlooked that one.

@byCedric byCedric requested a review from sjchmiela June 7, 2024 16:44
@byCedric byCedric changed the title chore: update node versions to test with to 18, 20, 22 chore!: drop support for Node 16 Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

✅ Thank you for adding the changelog entry!

@byCedric byCedric merged commit eb4c5e0 into main Jun 8, 2024
10 checks passed
@byCedric byCedric deleted the @bycedric/fix/workflow-node-versions branch June 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants