[eas-cli] add target-profile and source-profile flags to eas build:resign
#2410
Conversation
|
@d4rky-pl do you want to take a look? |
|
/changelog-entry new-feature Add |
|
Size Change: +596 B (0%) Total Size: 51.3 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 530 530
Lines 19509 19509
Branches 3968 3968
=======================================
Hits 10427 10427
Misses 8330 8330
Partials 752 752 ☔ View full report in Codecov by Sentry. |
| 'Name of the target build profile from eas.json. Used to resolve credentials for re-signing. Defaults to "production" if defined in eas.json.', | ||
| helpValue: 'PROFILE_NAME', | ||
| aliases: ['profile'], | ||
| }), | ||
| 'source-profile': Flags.string({ | ||
| description: | ||
| 'Name of the source build profile from eas.json. Used to filter builds eligible for re-signing.', |
There was a problem hiding this comment.
I don't think descriptions are really helpful. Will users know what these refer to?
There was a problem hiding this comment.
I hope so, I mean I understood it and I assumed that everybody else would also understand 😅. But maybe that's not the case 😂. Do you have any suggestions about how I can improve it?
There was a problem hiding this comment.
The source-profile description seems clear enough to me but I agree the target-profile description may not be immediately obvious if you don't have the context (that I now have after reading your explanation in #2404)
I'm afraid I can't come up with a better suggestion right now (traveling and not in the right space to think carefully) but I can take a second look next week if nobody else steps in to help :)
There was a problem hiding this comment.
Maybe Name of the target build profile from eas.json. Credentials and environment variables from this profile will be used when re-signing. Defaults to "production" if defined in eas.json. ?
…d-profile-argument-when-listing-builds-in-interactive-mode
|
✅ Thank you for adding the changelog entry! |
szdziedzic
deleted the
@szdziedzic/make-resign-command-respect-build-profile-argument-when-listing-builds-in-interactive-mode
branch
Why
#2404
How
Add 2 new flags:
source-profiletarget-profileThe previous
profileflag was really atarget-profile, so it can be an alias for it so we don't introduce a breaking change.See #2404 for more context
Test Plan
Test manually