Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] display build profile in eas build:list command details #2408

Merged

Conversation

szdziedzic
Copy link
Member

Why

When looking at #2404 I noticed that we don't display build profile info in this list, yet we allow people to filter by it which makes it confusing

How

Display build profile info as well

Test Plan

test manually

Copy link

github-actions bot commented Jun 5, 2024

Size Change: +1.4 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB +1.4 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (3fcbcf5) to head (5bdcef1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2408   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         530      530           
  Lines       19509    19509           
  Branches     3968     3968           
=======================================
  Hits        10427    10427           
  Misses       8330     8330           
  Partials      752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic
Copy link
Member Author

/changelog-entry new-feature Display build profile in the output of eas build:list

Copy link

github-actions bot commented Jun 5, 2024

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit f38a739 into main Jun 6, 2024
9 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/display-build-profile-in-eas-build-list-command branch June 6, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants