Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] use BuildMode.REPACK for --repack builds #2390

Merged
merged 1 commit into from
May 28, 2024

Conversation

szdziedzic
Copy link
Member

Why

use BuildMode.REPACK for --repack builds

How

use BuildMode.REPACK for --repack builds

Test Plan

run repack build locally

Copy link

github-actions bot commented May 21, 2024

Size Change: -397 B (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -397 B (0%)

compressed-size-action

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 53.41%. Comparing base (466339b) to head (dd102e6).

Files Patch % Lines
packages/eas-cli/src/build/android/prepareJob.ts 0.00% 6 Missing ⚠️
packages/eas-cli/src/build/ios/prepareJob.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2390      +/-   ##
==========================================
- Coverage   53.43%   53.41%   -0.02%     
==========================================
  Files         530      530              
  Lines       19516    19526      +10     
  Branches     3963     3967       +4     
==========================================
  Hits        10427    10427              
- Misses       8337     8347      +10     
  Partials      752      752              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label May 21, 2024
@szdziedzic szdziedzic force-pushed the @szdziedzic/use-repack-build-mode branch from 938c5d5 to dd102e6 Compare May 28, 2024 09:42
@szdziedzic szdziedzic added no changelog PR that doesn't require a changelog entry and removed no changelog PR that doesn't require a changelog entry labels May 28, 2024
@szdziedzic szdziedzic merged commit f0e3b64 into main May 28, 2024
10 of 11 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/use-repack-build-mode branch May 28, 2024 09:52
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants