Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] install dependencies before resolving expo config in init:onboarding #2380

Merged

Conversation

szdziedzic
Copy link
Member

Why

install dependencies before resolving the expo config

How

install dependencies before resolving the expo config

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label May 13, 2024
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

Size Change: -2.49 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -2.49 kB (0%)

compressed-size-action

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.46%. Comparing base (a6f7d37) to head (7c1de15).

Files Patch % Lines
...ackages/eas-cli/src/commands/project/onboarding.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2380   +/-   ##
=======================================
  Coverage   53.46%   53.46%           
=======================================
  Files         530      530           
  Lines       19502    19502           
  Branches     3959     3959           
=======================================
  Hits        10424    10424           
  Misses       8326     8326           
  Partials      752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic merged commit d6f3784 into main May 13, 2024
9 of 10 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/install-dependencies-before-resolving-expo-config branch May 13, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants