Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] create keystore for Android emulator builds in init:onboarding #2379

Merged

Conversation

szdziedzic
Copy link
Member

Why

https://exponent-internal.slack.com/archives/C06EBFAVCEA/p1715397103308639

create keystore for Android emulator builds in init:onboarding

How

create keystore for Android emulator builds in init:onboarding

Test Plan

test manually

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label May 13, 2024
@szdziedzic szdziedzic requested review from Simek and tchayen May 13, 2024 11:33
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 53.54%. Comparing base (e1ebcc0) to head (13671ef).
Report is 1 commits behind head on main.

Files Patch % Lines
...ackages/eas-cli/src/commands/project/onboarding.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2379      +/-   ##
==========================================
- Coverage   53.55%   53.54%   -0.01%     
==========================================
  Files         530      530              
  Lines       19513    19517       +4     
  Branches     4135     4139       +4     
==========================================
  Hits        10449    10449              
- Misses       8332     8336       +4     
  Partials      732      732              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 13, 2024

Size Change: +972 B (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB +972 B (0%)

compressed-size-action

Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@szdziedzic szdziedzic merged commit 57928d1 into main May 13, 2024
9 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/create-keystor-for-android-emulator-builds branch May 13, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant