[eas-cli] diagnostics: add loader and progress information #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.43 kB (0%) Total Size: 51.3 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
- Coverage 53.55% 53.55% -0.00%
==========================================
Files 530 530
Lines 19513 19517 +4
Branches 4135 4135
==========================================
+ Hits 10449 10451 +2
- Misses 8332 8334 +2
Partials 732 732 ☔ View full report in Codecov by Sentry. |
|
/changelog-entry chore Add loader and progress information to |
|
✅ Thank you for adding the changelog entry! |
szdziedzic
reviewed
May 13, 2024
Comment on lines
+25
to
28
| const spinner = ora().start(`Gathering diagnostic information...`); | ||
| const info = await envinfo.run( | ||
| { | ||
| System: ['OS', 'Shell'], |
There was a problem hiding this comment.
Maybe we should try / catch it and call spinner.failed when there is an error?
There was a problem hiding this comment.
AFAIK envinfo always "succeedes" and only prints error messages instead of throwing on read failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Let's give users an information that something is happening when
diagnosticstake a while to gather data.How
Add Ora spinner with simple process progress information + small formatting tweaks.
Test Plan
The changes have been tested locally.
Preview
Kapture.2024-05-13.at.13.29.27.mp4