Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add init:onboarding flow for no gh repo connected #2373

Conversation

szdziedzic
Copy link
Member

Why

add init:onboarding flow for no gh repo connected

How

  • clone default expo template
  • reset git repo
  • generate needed app.json and eas.json
  • install expo libs (updates, dev client, insights)
  • run a build

Test Plan

test manually

Copy link

github-actions bot commented May 10, 2024

Size Change: -7.95 kB (-0.02%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -7.95 kB (-0.02%)

compressed-size-action

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 11.00000% with 89 lines in your changes are missing coverage. Please review.

Project coverage is 53.47%. Comparing base (6dc9253) to head (043d088).
Report is 7 commits behind head on main.

Files Patch % Lines
...ackages/eas-cli/src/commands/project/onboarding.ts 11.54% 66 Missing and 3 partials ⚠️
packages/eas-cli/src/vcs/clients/git.ts 10.00% 8 Missing and 1 partial ⚠️
packages/eas-cli/src/build/runBuildAndSubmit.ts 0.00% 8 Missing ⚠️
packages/eas-cli/src/onboarding/runCommand.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/utils/expoUpdatesCli.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/vcs/git.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2373      +/-   ##
==========================================
- Coverage   53.56%   53.47%   -0.08%     
==========================================
  Files         530      530              
  Lines       19512    19494      -18     
  Branches     4134     3955     -179     
==========================================
- Hits        10449    10422      -27     
+ Misses       8332     8320      -12     
- Partials      731      752      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tchayen tchayen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onboarding-related parts look good to me.

Ideally in future we would be able to avoid repeating the backend code but for now I don't see any obvious way to do it.

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label May 13, 2024
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@szdziedzic szdziedzic merged commit ff9d533 into main May 13, 2024
6 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/add-eas-init-onboarding-flow-for-no-gh-repo-configured branch May 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants