-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] add init:onboarding
flow for no gh repo connected
#2373
[eas-cli] add init:onboarding
flow for no gh repo connected
#2373
Conversation
Size Change: -7.95 kB (-0.02%) Total Size: 51.3 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2373 +/- ##
==========================================
- Coverage 53.56% 53.47% -0.08%
==========================================
Files 530 530
Lines 19512 19494 -18
Branches 4134 3955 -179
==========================================
- Hits 10449 10422 -27
+ Misses 8332 8320 -12
- Partials 731 752 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The onboarding-related parts look good to me.
Ideally in future we would be able to avoid repeating the backend code but for now I don't see any obvious way to do it.
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Why
add
init:onboarding
flow for no gh repo connectedHow
Test Plan
test manually