Upgrade eas-build dependencies #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/changelog-entry chore Upgrade |
szdziedzic
approved these changes
May 6, 2024
|
✅ Thank you for adding the changelog entry! |
sjchmiela
approved these changes
May 7, 2024
|
Size Change: +237 B (0%) Total Size: 51.3 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
- Coverage 53.84% 53.83% -0.00%
==========================================
Files 525 525
Lines 19273 19275 +2
Branches 4073 4074 +1
==========================================
Hits 10375 10375
- Misses 8178 8180 +2
Partials 720 720 ☔ View full report in Codecov by Sentry. |
szdziedzic
approved these changes
May 8, 2024
| @@ -73,7 +73,6 @@ export async function prepareJobAsync( | |||
| secrets: { | |||
| buildCredentials, | |||
| }, | |||
| releaseChannel: buildProfile.releaseChannel, | |||
There was a problem hiding this comment.
It's safe right? I mean this is legacy channel so it should be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️ Upgrades
eas-builddependencies.